Skip to content

Fix bug with global params in get queries #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix bug with global params in get queries #51

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions lib/click_house/extend/connection_selective.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@ module Extend
module ConnectionSelective
# @return [ResultSet]
def select_all(sql)
response = get(body: sql, query: { default_format: 'JSON' })
response = get(body: sql, query: query_defaults)
Response::Factory.response(response, config)
end

def select_value(sql)
response = get(body: sql, query: { default_format: 'JSON' })
response = get(body: sql, query: query_defaults)
got = Response::Factory.response(response, config).first

case got
Expand All @@ -24,9 +24,13 @@ def select_value(sql)
end

def select_one(sql)
response = get(body: sql, query: { default_format: 'JSON' })
response = get(body: sql, query: query_defaults)
Response::Factory.response(response, config).first
end

def query_defaults
config.global_params.merge({default_format: 'JSON'})
end
end
end
end