Skip to content

Conversation

shivasurya
Copy link
Owner

@shivasurya shivasurya commented Nov 3, 2024

Description:

This PR attempts to add IfStmt, ForStmt, WhileStmt, DoWhileStmt entity support with predicate support.

  1. GetCondition
  2. GetElse
  3. GetThen
  4. GetAPrimaryQlClass
  5. ToString

Example query:

FROM IfStmt AS ifs
WHERE ifs.toString() != "null"
SELECT ifs.getIfStmt().GetCondition(), ifs.getIfStmt().GetThen() 

Checklist:

  • Tests passing (gradle testGo)?
  • Lint passing (golangci-lint run this requires golangci-lint)?

@shivasurya shivasurya added the enhancement New feature or request label Nov 3, 2024
@shivasurya shivasurya self-assigned this Nov 3, 2024
@shivasurya shivasurya changed the title Shiva/statement impl feature: IfStmt and Generic Statement support Nov 3, 2024
Copy link

codecov bot commented Nov 3, 2024

Codecov Report

Attention: Patch coverage is 80.76923% with 45 lines in your changes missing coverage. Please review.

Project coverage is 73.53%. Comparing base (5094373) to head (470ae1e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
sourcecode-parser/model/container.go 46.93% 26 Missing ⚠️
sourcecode-parser/graph/query.go 55.55% 16 Missing ⚠️
sourcecode-parser/graph/construct.go 97.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #173      +/-   ##
==========================================
+ Coverage   72.56%   73.53%   +0.97%     
==========================================
  Files          12       15       +3     
  Lines        1950     2184     +234     
==========================================
+ Hits         1415     1606     +191     
- Misses        496      538      +42     
- Partials       39       40       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shivasurya shivasurya force-pushed the shiva/statement-impl branch from e1a0f62 to b1d5736 Compare November 4, 2024 00:50
@shivasurya shivasurya changed the title feature: IfStmt and Generic Statement support feature: IfStmt, DoStmt, WhileStmt, ForStmt and Generic Statement support Nov 4, 2024
@shivasurya shivasurya merged commit d6d1f4d into main Nov 4, 2024
4 checks passed
@shivasurya shivasurya deleted the shiva/statement-impl branch November 4, 2024 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant