Skip to content

Commit

Permalink
Bump node version to 20 in action.yml
Browse files Browse the repository at this point in the history 
Node 16 is EOL on 2023-09-11 so we update it to Node 20 that was added in the actions/runner in v2.308.0
  • Loading branch information
@shivammathur
shivammathur committed Sep 13, 2023
1 parent 6207829 commit 5d259c6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion action.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,5 +31,5 @@ outputs:
php-version:
description: 'PHP version in semver format'
runs:
using: 'node16'
using: 'node20'
main: 'dist/index.js'

4 comments on commit 5d259c6

@Meroje
Copy link

@Meroje Meroje commented on 5d259c6 Sep 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shivammathur would you consider making this a major version bump like github does on their own actions ?

@shivammathur
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I understand that technically this is a breaking change, but practically for this reason creating a major version is not a good idea for the following reasons.

  • Creating a major version for this change affects a larger number of users than this should. Everyone using the v2 tag will have to edit the workflows to get the bug-fixes in this release even if they are not using the self-hosted runners.
  • For a long time, setup-php will have to support 2 major versions and that is very difficult for a project with a bus factor of 1 and less than 300$/month in funding.
  • For most users self-hosted runners update automatically, so this should be seamless.

It mostly affects enterprise users who maintain containerized runners fixed to a version but use the v2 tag for setup-php. But in that case, one should have a method in place to update your images regardless of the action versioning in case the runner releases a new version. Also using a semver tag for setup-php would be a good idea in the images.

As a policy, unless there is a breaking change in the setup-php API we will not tag a major version.

@fofort
Copy link

@fofort fofort commented on 5d259c6 Sep 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shivammathur is there a way to use different version of node, in my case would still need node 16? Thanks

@shivammathur
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fofort The previous version of the action 2.25.5 should work.

Please sign in to comment.