fix: alibaba#312

shitou321 · Jun 12, 2018 · 4da2bb1 · 4da2bb1
1 parent 354999c
commit 4da2bb1
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/...md/src/main/java/com/alibaba/p3c/pmd/lang/java/rule/oop/PojoMustOverrideToStringRule.java b/...md/src/main/java/com/alibaba/p3c/pmd/lang/java/rule/oop/PojoMustOverrideToStringRule.java
@@ -59,6 +59,10 @@ public class PojoMustOverrideToStringRule extends AbstractPojoRule {
 
     @Override
     public Object visit(ASTClassOrInterfaceDeclaration node, Object data) {
+        if (node.isInterface()) {
+            return super.visit(node, data);
+        }
+
         if (!isPojo(node)) {
             return super.visit(node, data);
         }

diff --git a/...est/resources/com/alibaba/p3c/pmd/lang/java/rule/oop/xml/PojoMustOverrideToStringRule.xml b/...est/resources/com/alibaba/p3c/pmd/lang/java/rule/oop/xml/PojoMustOverrideToStringRule.xml
@@ -132,4 +132,19 @@
 		<expected-problems>0</expected-problems>
 		<code-ref id="lombok-pojo-4" />
 	</test-code>
+
+	<!-- ====================================================================== -->
+
+	<code-fragment id="interface-with-pojo-surfix">
+		<![CDATA[
+	public interface FooDO {
+	}
+		]]>
+	</code-fragment>
+	<test-code>
+		<description>interface with POJO surfix</description>
+		<expected-problems>0</expected-problems>
+		<code-ref id="interface-with-pojo-surfix" />
+	</test-code>
+
 </test-data>