Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running 2.10.6 and noticed after updating to latest version that the booru was running way, way slower. I tracked it down to the truncate function, which was struggling with the thousands of words in the recent comments.
This PR severely improves the performance:
Before patch
After patch
The reason this is ultimately faster is that 1. the UTF-8 decoding is only executed once (vs multiple times as current for mb_strlen, mb_strrpos, mb_substr...), and 2. by calling mb_substr before, we will guarantee the length comparison will be bound to max ~50 characters (as opposed to strlen(a) != strlen(b) which will have to process all bytes in a and b to check their length).