Log error when getPosition() returns a bad offset

Work for vrapper#657.
shiraeeshi · Jun 26, 2015 · a2e80be · a2e80be
1 parent 58c1b6c
commit a2e80be
Showing 1 changed file with 16 additions and 2 deletions.
diff --git a/...apper.eclipse/src/net/sourceforge/vrapper/eclipse/platform/EclipseCursorAndSelection.java b/...apper.eclipse/src/net/sourceforge/vrapper/eclipse/platform/EclipseCursorAndSelection.java
@@ -427,7 +427,14 @@ public void widgetSelected(final SelectionEvent arg0) {
             if ( ! selectionInProgress) {
                 selection = null;
                 // getPosition() compensates for inclusive visual selection's caret offset.
-                updateStickyColumn(getPosition().getViewOffset());
+                Position position = getPosition();
+                int viewOffset = position.getViewOffset();
+                if (viewOffset >= 0) {
+                    updateStickyColumn(viewOffset);
+                } else {
+                    VrapperLog.error("Cannot update stick column: caret is at position M"
+                            + position.getModelOffset() + " but" + " viewoffset is -1!");
+                }
             }
         }
 
@@ -436,7 +443,14 @@ public void selectionChanged(SelectionChangedEvent event) {
             if ( ! selectionInProgress) {
                 selection = null;
                 // getPosition() compensates for inclusive visual selection's caret offset.
-                updateStickyColumn(getPosition().getViewOffset());
+                Position position = getPosition();
+                int viewOffset = position.getViewOffset();
+                if (viewOffset >= 0) {
+                    updateStickyColumn(viewOffset);
+                } else {
+                    VrapperLog.error("Cannot update stick column: caret is at position M"
+                            + position.getModelOffset() + " but" + " viewoffset is -1!");
+                }
             }
         }
     }