Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional URLs to environment. #4

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dacbd
Copy link

@dacbd dacbd commented Jul 9, 2024

The previous PR looked dead, includes the PR comment + a change to silence some LSP complaints.

To elaborate on the LSP complaint, your exit function does call sys.exit effectively terminating the program.
However the LSP(I'm using pyright) doesn't properly detect this effectively ends function and complains that response is potentionally unbound, since there is no explict return/hault detected. I believe this has to do with how finally works in a try block. Code could continue executing in that scope (if there was a finally) and thus the LSP complains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant