Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous PR looked dead, includes the PR comment + a change to silence some LSP complaints.
To elaborate on the LSP complaint, your exit function does call
sys.exit
effectively terminating the program.However the LSP(I'm using pyright) doesn't properly detect this effectively ends function and complains that
response
is potentionally unbound, since there is no explict return/hault detected. I believe this has to do with howfinally
works in atry
block. Code could continue executing in that scope (if there was afinally
) and thus the LSP complains.