fix: trimChars() handle for null #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The shipping phone number and street line 2 can be set as optional fields in Magento so these fields can come in as null when exporting orders which was causing the
trimChars()method to throw an exception.Solution
Allow nullable input values for the
trimChars()methodTesting
Running a local instance of Magento2 I disabled the shipping phone number and shipping street line 2 fields through the admin panel. Then with the updated Autcane API plugin locally installed on my Magento store I tested exporting orders and confirmed the expected output.