Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for the wrong type definition of StepOptions.scrollTo #494

Merged
merged 1 commit into from
Aug 9, 2019
Merged

Fix for the wrong type definition of StepOptions.scrollTo #494

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/types/step.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ declare namespace Step {
/**
* Should the element be scrolled to when this step is shown?
*/
scrollTo?: boolean;
scrollTo?: boolean | ScrollIntoViewOptions;
Copy link
Member

@RobbieTheWagner RobbieTheWagner Aug 9, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ScrollIntoViewOptions is not defined. We'll need to add it as well, won't we?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is built into TS, so should be okay.


/**
* A function that lets you override the default scrollTo behavior and
Expand Down