Allow to specify scrollIntoView behavior #398 #401
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobbieTheWagner
changed the title
RobbieTheWagner
requested changes
Jun 12, 2019
| @@ -4,6 +4,7 @@ import { Evented } from './evented.js'; | |||
| import 'element-matches'; | |||
| import { bindAdvance, bindButtonEvents, bindCancelLink, bindMethods } from './utils/bind.js'; | |||
| import { createFromHTML, setupTooltip, parseAttachTo } from './utils/general.js'; | |||
| import { isBoolean } from 'util'; | |||
There was a problem hiding this comment.
I don't believe util is a file and I also don't think we have an isBoolean.
RobbieTheWagner
added a commit
that referenced
this pull request
Jun 12, 2019
This should enable users to pass options like `scrollTo: { behavior: 'smooth', block: 'center' },` which will change the scrolling behavior to center the object and to scroll smoothly. These options come from https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollIntoView
The `behavior` option is not supported in Safari or IE, so we added a polyfill for them.
Closes #398
Closes #401
RobbieTheWagner
added a commit
that referenced
this pull request
Jun 12, 2019
This should enable users to pass options like `scrollTo: { behavior: 'smooth', block: 'center' },` which will change the scrolling behavior to center the object and to scroll smoothly. These options come from https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollIntoView
The `behavior` option is not supported in Safari or IE, so we added a polyfill for them.
Closes #398
Closes #401
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#398