Allow centering a step over a specific element #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No argument here. This needs to be rebased as well due to the last PR that was merged. |
jezstephens
force-pushed
the
attach-to-center
branch
from
41cd37c to
4701f9a
Compare
|
Done! |
b-ash
added a commit
that referenced
this pull request
Jan 26, 2015
Allow centering a step over a specific element
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's useful to be able to be able to center a step over a particular element, for example when you have a large element which occupies the whole screen which you need to explain.
This change lets you do this with
attachTo: '#widget center'orattachTo: {element: '#widget', on: 'center'}.