Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: stop ontouchstart events on overlay #302

Merged
merged 3 commits into from
Dec 24, 2018

Conversation

chuckcarpenter
Copy link
Member

This branch stops the ability on iOS (where overflow: hidden doesn't work) to pull the overlay window out of place and move the mask highlight out of place.

🚈

src/js/tour.js Outdated Show resolved Hide resolved
src/js/tour.js Outdated Show resolved Hide resolved
@BrianSipple
Copy link
Contributor

Some questions regarding where we call this from, but overall LGTM 👍

@chuckcarpenter
Copy link
Member Author

@BrianSipple that makes sense to me and I've updated.

@RobbieTheWagner RobbieTheWagner merged commit ac629c8 into modal-functionality Dec 24, 2018
@RobbieTheWagner RobbieTheWagner deleted the modal-pull-scroll branch December 24, 2018 03:39
RobbieTheWagner pushed a commit that referenced this pull request Dec 31, 2018
* fix: stop pull on overlap

* fix: selector for overlay

* update listener calls to match previous utils
RobbieTheWagner pushed a commit that referenced this pull request Dec 31, 2018
…301)

* integrate modal functionality that was originally in Ember Shepherd

* Fix: stop ontouchstart events on overlay (#302)

* fix: stop pull on overlap

* fix: selector for overlay

* update listener calls to match previous utils

* Add modal and highlight tests

* Bump some deps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants