✨ Update shepherd element to use html dialog #2982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
chuckcarpenter
commented
Sep 20, 2024
| @@ -141,20 +141,20 @@ | |||
| class:shepherd-element={true} | |||
| {...dataStepId} | |||
| on:keydown={handleKeyDown} | |||
| role="dialog" | |||
| tabindex="0" | |||
There was a problem hiding this comment.
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/dialog#attributes
Warning: The tabindex attribute must not be used on the element.
chuckcarpenter
commented
Sep 20, 2024
|
|
||
| <style global> | ||
| .shepherd-element { | ||
| background: #fff; | ||
| border-radius: 5px; | ||
| box-shadow: 0 1px 4px rgba(0, 0, 0, 0.2); | ||
| margin: 0; |
There was a problem hiding this comment.
margin auto is a default in the browser
RobbieTheWagner
approved these changes
Oct 8, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue addresses the request for semantic HTML and closes #2959.