Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seeming contradiction in documentation #138

Closed
itsjoesullivan opened this issue Oct 10, 2016 · 1 comment
Closed

Seeming contradiction in documentation #138

itsjoesullivan opened this issue Oct 10, 2016 · 1 comment
Labels
duplicate

Comments

@itsjoesullivan
Copy link

itsjoesullivan commented Oct 10, 2016 •
edited
Loading

It took me a bit to identify that addStep is returning a Tour, and not a Step, due to the following in the documentation:

image

and

image

I would submit a PR correcting the documentation, except that I prefer the opposite behavior of addStep.
@RobbieTheWagner
Copy link
Member

This has been mentioned a couple times. There is an issue here #165. I think we should go ahead and return the step, so I will get that merged in now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@itsjoesullivan @RobbieTheWagner