Merge pull request #5 from desktime/add-scroll-method

Adds a scrollToHandler option to Shepherd Defaults.
shipshapecode · Jan 23, 2015 · 1b1bd9a · 1b1bd9a
2 parents 98f313a + 1cb3a89
commit 1b1bd9a
Show file tree

Hide file tree

Showing 6 changed files with 21 additions and 6 deletions.
diff --git a/coffee/shepherd.coffee b/coffee/shepherd.coffee
@@ -156,7 +156,10 @@ class Step extends Evented
   scrollTo: =>
     {element} = @getAttachTo()
 
-    element?.scrollIntoView()
+    if @options.scrollToHandler?
+      @options.scrollToHandler(element) 
+    else
+      element?.scrollIntoView()
 
   destroy: =>
     if @el?

diff --git a/js/shepherd.js b/js/shepherd.js
diff --git a/shepherd-amd.js b/shepherd-amd.js
@@ -212,7 +212,11 @@
     Step.prototype.scrollTo = function() {
       var element;
       element = this.getAttachTo().element;
-      return element != null ? element.scrollIntoView() : void 0;
+      if (this.options.scrollToHandler != null) {
+        return this.options.scrollToHandler(element);
+      } else {
+        return element != null ? element.scrollIntoView() : void 0;
+      }
     };
 
     Step.prototype.destroy = function() {

diff --git a/shepherd-amd.min.js b/shepherd-amd.min.js
diff --git a/shepherd.js b/shepherd.js
@@ -1645,7 +1645,11 @@ return this.Tether;
     Step.prototype.scrollTo = function() {
       var element;
       element = this.getAttachTo().element;
-      return element != null ? element.scrollIntoView() : void 0;
+      if (this.options.scrollToHandler != null) {
+        return this.options.scrollToHandler(element);
+      } else {
+        return element != null ? element.scrollIntoView() : void 0;
+      }
     };
 
     Step.prototype.destroy = function() {

diff --git a/shepherd.min.js b/shepherd.min.js