Update docker-compose.yml

[morpheus7CS]

Hi @fideloper,

I have just started using Vessel today and upon running ./vessel start MySQL container immediately exited with status Exit (1). It took me some time to find the issue in the first place as well as coming up with the right syntax.

I have added a commented out line for MYSQL_ALLOW_EMPTY_PASSWORD: 'yes' to the default docker-compose.yml file. As Laravel uses this by default on a new .env file, I thought it useful for newcomers and gives them the solution right there.

Furthermore, as you have referenced this as an issue a while back, I'm willing to lend a hand with the documentation, if you find you need any help. If you merge this option, I can update the docs accordingly. Let me know.

Kind regards,
g

[fideloper]

Thanks for letting me know, I didn't catch that laravel's default is to have an empty password now!

[fideloper]

I wonder if we want to have this line NOT commented out so it takes effect. In theory that shouldn't break it if the password is NOT empty?

[morpheus7CS]

Hey, true. But the question I had was: would a new user try to actually deploy using this file, therefore possibly opening up the production DB to the World?

This is why I have commented it out, but maybe it makes sense to actually have it uncommented.

[fideloper]

welllllll I'm not sure I care about that use case when I specifically tell people this is for development only....

…

On Wed, Jul 3, 2019 at 3:27 PM Gal Jakič ***@***.***> wrote: Hey, true. But the question I had was: would a new user try to actually deploy using this file, therefore possibly opening up the production DB to the World? This is why I have commented it out, but maybe it makes sense to actually have it uncommented. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#112?email_source=notifications&email_token=AADSDUZXMRMTAGPNM6EDOSDP5UDRJA5CNFSM4H5JIVB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZFSZCY#issuecomment-508243083>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADSDU56PESGEZNOPSSQKKTP5UDRJANCNFSM4H5JIVBQ> .

[fideloper]

Sorry I lost track of this, I went and had a baby and that's a bit distracting :D

If you want, can you add that line but keep it uncommented? I think that'll work best in terms of not being a surprise for Vessel users going forward.

[morpheus7CS]

Sure, give me 5 minutes.

P.S. Totally understand the baby situation, have been there myself a few years back. ;)

[fideloper]

Thanks!!