Skip to content
This repository has been archived by the owner on Mar 14, 2023. It is now read-only.

[Feature]: SSH Verbosity Levels #191

Merged
merged 6 commits into from
Apr 27, 2018
Merged

[Feature]: SSH Verbosity Levels #191

merged 6 commits into from
Apr 27, 2018

Conversation

mitchtreece
Copy link
Contributor

Added the ability to specify an optional SSH verbosity level in the shipit configuration file.

{
    ...

    // 0 (none), 1 (-v), 2 (-vv), 3 (-vvv)
    // Defaults to `none`
    verboseSSHLevel: 1
}

@mitchtreece mitchtreece mentioned this pull request Apr 23, 2018
Open
@codecov-io
Copy link

codecov-io commented Apr 23, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@a764fff). Click here to learn what that means.
The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #191   +/-   ##
=========================================
  Coverage          ?   80.96%           
=========================================
  Files             ?       26           
  Lines             ?      562           
  Branches          ?      112           
=========================================
  Hits              ?      455           
  Misses            ?       78           
  Partials          ?       29
Impacted Files Coverage Δ
packages/shipit-cli/src/Shipit.js 57.33% <ø> (ø)
packages/ssh-pool/src/Connection.js 97.43% <ø> (ø)
packages/ssh-pool/src/commands/ssh.js 48.27% <14.28%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a764fff...3a29a61. Read the comment docs.

gregberge
gregberge suggested changes Apr 24, 2018
View reviewed changes
README.md Outdated
@@ -1,5 +1,5 @@
<h1 align="center">
<img src="https://raw.githubusercontent.com/shipitjs/shipit/master/ressources/shipit-logo.png" alt="Shipit" title="Shipit" width="500">
<img src="./resources/shipit-logo.png" alt="Shipit" title="Shipit" width="500">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broken in diff.

.gitignore Outdated
@@ -2,3 +2,4 @@ node_modules/
packages/*/lib
coverage/
.eslintcache
.DS_Store
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be in your global .gitignore, please remove it.

package.json Outdated
"workspaces": [
"packages/*"
],
"dependencies": {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary changes please, remove it.

packages/shipit-cli/src/Shipit.js Outdated
@@ -158,6 +158,7 @@ class Shipit extends Orchestrator {
...this.options,
key: this.config.key,
strict: this.config.strict,
verbosityLevel: Object.is(this.config.verboseSSHLevel, undefined) ? 0 : this.config.verboseSSHLevel
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Object.is is not compatible with old version, === will be fine.

@gregberge
Copy link
Member

Thanks for your PR, just a few minor changes please.

@mitchtreece
Copy link
Contributor Author

@neoziro Updated! 😃

@gregberge
Copy link
Member

@mitchtreece good! A last thing, can you please update all readme to reflect the change?

@mitchtreece
Copy link
Contributor Author

@neoziro You got it. Updated! 🎉

@gregberge
Copy link
Member

I think you missed this one https://github.com/shipitjs/shipit/blob/master/packages/ssh-pool/README.md

@mitchtreece
Copy link
Contributor Author

@neoziro Oops. Should be good now!

@gregberge gregberge merged commit 327c63e into shipitjs:master Apr 27, 2018
@gregberge
Copy link
Member

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gregberge gregberge gregberge approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mitchtreece @codecov-io @gregberge