fix(shipit-deploy): only remove workspace if not shallow clone (#200)

shipitjs · Jun 14, 2018 · 6ba6f00 · 6ba6f00
1 parent f66c2bb
commit 6ba6f00
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 4 deletions.
diff --git a/packages/shipit-deploy/src/tasks/deploy/update.js b/packages/shipit-deploy/src/tasks/deploy/update.js
@@ -135,9 +135,11 @@ const updateTask = shipit => {
     }
 
     async function removeWorkspace() {
-      shipit.log(`Removing workspace "${shipit.workspace}"`)
-      await rmfr(shipit.workspace)
-      shipit.log(chalk.green('Workspace removed.'))
+      if (shipit.config.shallowClone) {
+        shipit.log(`Removing workspace "${shipit.workspace}"`)
+        await rmfr(shipit.workspace)
+        shipit.log(chalk.green('Workspace removed.'))
+      }
     }
 
     await setPreviousRelease()

diff --git a/packages/shipit-deploy/src/tasks/deploy/update.test.js b/packages/shipit-deploy/src/tasks/deploy/update.test.js
@@ -226,11 +226,21 @@ describe('deploy:update task', () => {
     })
   })
 
-  it('should remove workspace', async () => {
+  it('should remove workspace when shallow cloning', async () => {
+    shipit.config.shallowClone = true
     stubShipit(shipit)
     rmfr.mockClear()
     expect(rmfr).not.toHaveBeenCalled()
     await start(shipit, 'deploy:update')
     expect(rmfr).toHaveBeenCalledWith('/tmp/workspace')
   })
+
+  it('should keep workspace when not shallow cloning', async () => {
+    shipit.config.shallowClone = false
+    stubShipit(shipit)
+    rmfr.mockClear()
+    expect(rmfr).not.toHaveBeenCalled()
+    await start(shipit, 'deploy:update')
+    expect(rmfr).not.toHaveBeenCalledWith('/tmp/workspace')
+  })
 })