Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute cord/CSF ratio and removing T1w bloc #64

Merged
merged 10 commits into from
Jan 17, 2024
Merged

Conversation

jcohenadad
Copy link
Member

This PR removes the analysis of the T1w scans, given their poor relevance for the RF shimming paper. Instead, we introduce the computation of the cord/CSF ratio.

@jcohenadad
Copy link
Member Author

Encouraging preliminary results from c598978:

download

@jcohenadad jcohenadad merged commit 5055081 into main Jan 17, 2024
@jcohenadad jcohenadad deleted the jca/63-cord-csf-ratio branch January 17, 2024 18:42
@dpapp86
Copy link
Collaborator

dpapp86 commented Jan 17, 2024

@jcohenadad some comments

1, This now changes the argument from one based on signal intensity to one based on contrast. In this case, going for the CNR may be better?
2, It is hard to interpret, for example, the results for sub-03 (increase-decrease-increase), especially in light of the otherwise easier to interpret signal intensity within the CS itself
3, While I did some spot checks to see if the mask used for RF shim calculation does include all of the CSF on later scans (where we would expect more motion wrt the noshim case), this is not guaranteed, as it was not part of the experimental design. If in some slices, the VOI for RF shimming does not include the CSF, this might bias results
4, The optimisation algorithm was not "make the CNR between CSF and SC the best i could be", it was "make the B1+ field in the mask as homogeneous/high/etc as it can be". I am not sure one translates easily to the other.
5. B1- is a straight multiplicative field (at first approximation), and is, bar inter-scan motion, the same for all scans.
6, Please give me an @ next time before pushing through a PR of this magnitude, especially considering time zone differences.

@jcohenadad
Copy link
Member Author

1, This now changes the argument from one based on signal intensity to one based on contrast. In this case, going for the CNR may be better?

what we are really after is more homogeneous Tx, which means more homogeneous flip angle, which means more homogeneous contrast between two structures having a drastically different T1 (eg: CSF and SC). So to me, looking at the ratio makes much more sense.

2, It is hard to interpret, for example, the results for sub-03 (increase-decrease-increase), especially in light of the otherwise easier to interpret signal intensity within the CS itself

these are preliminary results-- hindered by #35

3, While I did some spot checks to see if the mask used for RF shim calculation does include all of the CSF on later scans (where we would expect more motion wrt the noshim case), this is not guaranteed, as it was not part of the experimental design. If in some slices, the VOI for RF shimming does not include the CSF, this might bias results

given the size of the Tx coils and their distance from the cord/CSF, this makes a negligible difference

4, The optimisation algorithm was not "make the CNR between CSF and SC the best i could be", it was "make the B1+ field in the mask as homogeneous/high/etc as it can be". I am not sure one translates easily to the other.

right, see point 1

  1. B1- is a straight multiplicative field (at first approximation), and is, bar inter-scan motion, the same for all scans.

right, but looking at curves that tell multiple stories is less straightforward than curves that only tell one story

6, Please give me an @ next time before pushing through a PR of this magnitude, especially considering time zone differences.

yes, sorry. In any case, if you are in any disagreement, it is very straightforward to revert changes with git. Conversation can always happen after the fact, and we can checkout a previous commit if we decide to. This is exactly the reason why working with atomic PR, addressing only a single issue, makes it easier to navigate the project in time in a collaborative manner.

@dpapp86
Copy link
Collaborator

dpapp86 commented Jan 17, 2024

Let's revisit after #35 is fixed, in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider quantifying the ratio cord/CSF signal
2 participants