Repository navigation
Migrate OpenCvSharp.sln to the .slnx solution format - #2059
Conversation
.NET 10/VS 2026 (already the baseline this repo targets in CI and TargetFrameworks) fully support the XML-based .slnx format, and no CI workflow builds the .sln directly, so there's no pipeline risk. Generated via `dotnet sln OpenCvSharp.sln migrate` and verified with a full Release|x64 build through VS 2026's MSBuild (native OpenCvSharpExtern + all managed projects + tests), then removed the old .sln. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe legacy ChangesSolution migration
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/build-instructions.md`:
- Line 52: Update the build instructions around OpenCvSharp.slnx to state that
opening or building it requires Visual Studio 2022 version 17.12 or later, or
another supported toolchain. Preserve the existing build guidance while clearly
qualifying the .slnx requirement.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 99e22dd3-9094-4865-a68d-b58816eab8aa
📒 Files selected for processing (3)
OpenCvSharp.slnOpenCvSharp.slnxdocs/build-instructions.md
💤 Files with no reviewable changes (1)
- OpenCvSharp.sln
Note the Visual Studio 2022 17.12+ requirement for opening/building .slnx solutions (MSBuild 17.12 added baseline .slnx support; earlier 17.x releases can't parse it). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Resolves the OpenCvSharp.sln/.slnx conflict: main migrated to the .slnx format (#2059) while this branch still edited the old .sln, so the new NativeAOT test project is registered in OpenCvSharp.slnx instead.
Summary
OpenCvSharp.slnwithOpenCvSharp.slnx(generated viadotnet sln OpenCvSharp.sln migrate), and updated the one active doc reference (docs/build-instructions.md) to point at the new file.OpenCvSharp.slndirectly (all Windows/Linux/macOS pipelines build individual.csproj/CMake targets), so this has no build-pipeline impact.net10.0/.NET 10 SDK and builds with the VS 2026 generator in CI, and.slnxis fully supported by VS 2022 17.13+, VS 2026, Rider 2024.3+, and the .NET 10 SDK CLI, so this isn't a premature move.Test plan
Release|x64build through VS 2026'sMSBuild.exeagainstOpenCvSharp.slnxsucceeds end-to-end (nativeOpenCvSharpExtern.vcxproj+ all managed projects +OpenCvSharp.Tests/.Tests.Windows/.Tests.Avalonia), exit code 0.Summary by CodeRabbit
.slnxformat.