Repository navigation
Migrate OpenCvSharp.Analyzers.Tests to xunit v3 - #2020
Conversation
Replace the obsolete Microsoft.CodeAnalysis.CSharp.Analyzer.Testing.XUnit package with the framework-agnostic Analyzer.Testing package and DefaultVerifier, and bump xunit/xunit.runner.visualstudio to v3 to match the other test projects. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThe test project's package references are updated to replace xunit v2 and the XUnit-specific analyzer testing package with xunit.v3, updated xunit.runner.visualstudio, and the base Microsoft.CodeAnalysis.CSharp.Analyzer.Testing package. Four analyzer test files switch their CSharpAnalyzerTest verifier from XUnitVerifier to DefaultVerifier, removing the corresponding using directive. Changesxunit v3 migration
Estimated code review effort: 1 (Trivial) | ~5 minutes Sequence Diagram(s)Not applicable — this change is a test-infrastructure dependency swap without new control flow or multi-component interaction. Related PRs: None identified. Suggested labels: tests, dependencies Suggested reviewers: shimat 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
test/OpenCvSharp.Analyzers.Testswas the only test project still on xunit v2, blocking the deprecatedMicrosoft.CodeAnalysis.CSharp.Analyzer.Testing.XUnit/xunitv2 dependencies from being auto-updated by Renovate.Microsoft.CodeAnalysis.CSharp.Analyzer.Testing.XUnitwith the framework-agnosticMicrosoft.CodeAnalysis.CSharp.Analyzer.Testingpackage, and swappedXUnitVerifierforDefaultVerifierin the four analyzer test files.xunit→xunit.v3(3.2.2) andxunit.runner.visualstudio→ 3.1.5, matching the other test projects (OpenCvSharp.Tests,OpenCvSharp.Tests.Windows).Test plan
dotnet buildsucceedsdotnet test— all 23 tests passCo-Authored-By: Claude Sonnet 5 noreply@anthropic.com
Summary by CodeRabbit