Repository navigation
Inline the one PInvokeHelper use and delete the class - #1973
Merged
Merged
Conversation
PInvokeHelper had only two members: CreateException (used solely by NativeMethods.TryPInvoke to wrap a DLL-load failure) and DllImportError (dead, no callers). Inline the trivial `new OpenCvSharpException(e.Message, e)` at the two TryPInvoke call sites and delete the class. TryPInvoke itself is kept: since #1753 it is no longer called automatically (that broke custom NativeLibrary.SetDllImportResolver registration) but remains public as an opt-in pre-flight DLL-load check. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@
Small cleanup (independent of the #1968–#1972 stack; based on
5.x).PInvokeHelperhad only two members:CreateException(Exception)— used in exactly one place,NativeMethods.TryPInvoke, to wrap a DLL-load failure asOpenCvSharpException.DllImportError(Exception)— dead (no callers).Inline the trivial
new OpenCvSharpException(e.Message, e)at the twoTryPInvokecall sites and delete the class.TryPInvokeis kept (on purpose)It has no callers, but that is by design: since #1753 it is no longer invoked automatically (the old static-constructor call ran the first P/Invoke before user code could register a custom
NativeLibrary.SetDllImportResolver). It remainspublicas an opt-in pre-flight DLL-load check that returns a friendly error for the most common support issue ("Unable to load DLL OpenCvSharpExtern"). So only the helper class is removed, not the diagnostic.Managed build green.
@