Repository navigation
Updated SolvePnPMethod enum. - #1899
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughXML documentation comments in the ChangesSolvePnPMethod XML Documentation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Sorry, I didn't see that you had also made the changes yourself in #1898 |
|
Thank you! |
Follow-up to shimat#1899. Tidies the SolvePnPMethod documentation without changing behavior: - Fix CS1570 warning: escape "&" as "&" in the P3P reference - Remove a redundant duplicated sentence in the SQPNP summary - Fix spacing/punctuation in the SQPNP reference ("M. Lourakis. It requires") - Trim trailing whitespace and add a missing period in several summaries Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The SolvePnPMethod enum was missing the last 4 values. I have added these values and updated the descriptions/summaries.
SolvePnp with SolvePnPMethod.SQPNP was successfully tested on a real world scenario.
Summary by CodeRabbit
SolvePnPMethodsolver method flags, including clearer descriptions for iterative (Levenberg–Marquardt), notes onDLS/UPNPlimitations, and updated guidance on point ordering forIPPE_SQUARE.