Ecosystem pagination #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patmellon
suggested changes
Jul 21, 2020
ecosystem/ecosystem.html
Outdated
Comment on lines
66
to
56
| <div id="ecosystem-index-cards"> | ||
| <div class="list row ecosystem-cards-wrapper"> | ||
| {% assign ecosystem = site.ecosystem | sort_natural: "title" %} | ||
|
|
||
| {% for item in ecosystem %} | ||
| <div class="col-md-6 ecosystem-card-wrapper" data-categories="{{ item.category | join: "," }}"> | ||
| <div class="card ecosystem-card"> | ||
| <a href="{{ item.link }}" target="_blank"> | ||
| <div class="card-body {{ item.logo-class }} {% if item.experimental %}experimental{% endif %}"> | ||
| <div class="ecosystem-card-title-container"> | ||
| <h4>{{ item.title }}</h4> | ||
| {% if item.experimental %} | ||
| <div class="experimental-badge"> | ||
| Experimental | ||
| </div> | ||
| {% endif %} | ||
| </div> | ||
| <p class="card-summary">{{ item.summary }}</p> |
There was a problem hiding this comment.
It looks like a lot of this is changed from the ecosystem-stars-final branch. It doesn't have any of the new data attributes we added. Can you make sure you're branching off of ecosystem-stars-final?
patmellon
reviewed
Jul 21, 2020
_sass/ecosystem.scss
Outdated
Comment on lines
365
to
373
| .ecosystem .pagination { | ||
| .page { | ||
| border: 1px solid #dee2e6; | ||
| padding: 0.5rem 0.75rem; | ||
| } | ||
|
|
||
| .active .page { | ||
| background-color: #dee2e6; | ||
|
|
There was a problem hiding this comment.
It looks like you're missing some closing curly braces.
Bgreen23
force-pushed
the
ecosystem-pagination
branch
from
92089db to
4715778
Compare
patmellon
suggested changes
Jul 21, 2020
ecosystem/ecosystem.html
Outdated
Comment on lines
126
to
129
| <script src="//cdnjs.cloudflare.com/ajax/libs/list.js/1.5.0/list.min.js"></script> | ||
| <script src="//cdnjs.cloudflare.com/ajax/libs/numeral.js/2.0.6/numeral.min.js"></script> | ||
| <script id="filter-script" ecosystem="true" star-count-call-date="ecosystemStarCountCallDate" star-count-data="ecosystemStarCountData" src="{{ site.baseurl }}/assets/github-stars.js"></script> | ||
| <script src="//cdnjs.cloudflare.com/ajax/libs/list.js/1.5.0/list.min.js"></script> | ||
| <script list-id="ecosystem-index-cards" display-count="100" pagination="false" src="{{ site.baseurl }}/assets/filter-hub-tags.js"></script> | ||
| <script list-id="ecosystem-index-cards" display-count="10" pagination="true" src="{{ site.baseurl }}/assets/filter-hub-tags.js"></script> |
There was a problem hiding this comment.
It looks like you have a merge conflict related to these scripts. Once you address the conflict then this should be good to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds pagination to the Ecosystem