Add an option to use the Windows title bar

[mon-jai]

Closes #285

Description

This pull request add an option to the preference dialog for enabling the Windows title bar.

Since restarting electron is required for changes to take effect, a dialog will be shown asking if user wanted to restart right away.

The two options, "custom" and "native" comes from the similar option in VS Code, so they should familiar enough for most users.

TODO:

• Fix comments
• Sort imports
• Rebase changes to a single commit

Screenshots

Release notes

Notes:

[mon-jai]

Hi @shiftkey. Should we get his merged before #911, or vice versa?

[shiftkey]

@mon-jai given the progress of that PR, I think we can land this one after

[shiftkey]

Some early thoughts on the diff of changes, as I haven't had a chance to run this code up and explore the feature in it's current form...

[mon-jai]

@mon-jai given the progress of that PR, I think we can land this one after

OK

[mon-jai]

@shiftkey I have rewritten app/src/lib/title-bar-config.ts to make it more in line with the API and caching design of app/src/lib/get-main-guid.ts.

Can you take a look and see if it is OK?

[mon-jai]

Screenshot of the updated UI:

Edit: use unordered list instead

Edit 2: full stop fixed

[Tankbog]

• [ ]

[mon-jai]

Double checked and squashed to a single commit. This should be ready for review.

[shiftkey]

This is feeling really close - just some polish and suggestions to wrap this up before I slide this into the next release...

[shiftkey]

I've just rebased this branch on top of the default branch here as there were some conflicts with the last couple of releases, but this is otherwise feeling close. I'm happy to take it over and resolve the last couple of things if you don't have time currently @mon-jai!

[mon-jai]

Thanks @shiftkey. I have resolved all conversations but do not have time yet to check the changes on a Linux PC.

I may have time after one to two weeks. In the meanwhile, if you could verify that the PR works, feel free to merge it, just remember to keep credit to me with Co-authored-by in the commit message.

[mon-jai]

@shiftkey Sorry for the late reply.

I have made some final UI fixes, tested the changes, and squashed them into a single commit.

The pull request is now ready for merging, remember to keep credit to me with Co-authored-by in the commit message..

Testing screencast:

Screencast.from.09-19-2023.05.39.44.PM.webm

[mon-jai]

Hi @shiftkey. Can you help reviewing the PR?

[shiftkey]

Hi @shiftkey. Can you help reviewing the PR?

I haven't forgotten this, just haven't had the time to sit down and give this one last look over. I'm also due to cut a new upstream release so I'll make sure to do both at the same time (probably this weekend).