switch Linux build over to use configured docker image#898
Conversation
Co-authored-by: theofficialgman <28281419+theofficialgman@users.noreply.github.com>
…s GLIBC 17 Co-authored-by: theofficialgman <28281419+theofficialgman@users.noreply.github.com>
|
not sure if you intend on fixing all the cross compilation issues in this PR but you are missingthe dist-info.ts and build.ts script changes implement however you want as long as the function is the same. your changes here are a nice cleanup, I hadn't thought of that (was just following the previous work) aff1c2b |
|
@theofficialgman 👍🏻 about to push that fix now |
script/build.ts
Outdated
There was a problem hiding this comment.
can't comment high enough. look up a few lines, in the file I refererenced to you. you need to change
if (
targetArch === 'arm64' ||
targetArch === 'x64' ||
targetArch === 'armv7l'
) {
return targetArch
}
its input is npm_config_arch and armv7l isn't valid input. arm is but the returned value needs to be armv7l (for electron packager)
There was a problem hiding this comment.
actually nvm. the functionality as it is will work, it will just be impossible to hit targetArch === 'armv7l' since npm_config_arch should never contain that and os.arch will never return that
6e47e94 to
ff301ac
Compare
|
also just an fyi, I can't mark any of these reviews as resolved. only you (the repo owner or the PR owner, in this case you are both) can do that |
Co-authored-by: theofficialgman <28281419+theofficialgman@users.noreply.github.com>
24d23dc to
47e1aa6
Compare
Co-authored-by: theofficialgman <28281419+theofficialgman@users.noreply.github.com>
Co-authored-by: theofficialgman <28281419+theofficialgman@users.noreply.github.com>
Co-authored-by: theofficialgman <28281419+theofficialgman@users.noreply.github.com>
…res (#898) Co-authored-by: theofficialgman <28281419+theofficialgman@users.noreply.github.com>
…res (#898) Co-authored-by: theofficialgman <28281419+theofficialgman@users.noreply.github.com>
Co-authored-by: theofficialgman <28281419+theofficialgman@users.noreply.github.com>
Co-authored-by: theofficialgman <28281419+theofficialgman@users.noreply.github.com>
… architectures (#898) Co-authored-by: theofficialgman <28281419+theofficialgman@users.noreply.github.com>
…res (#898) Co-authored-by: theofficialgman <28281419+theofficialgman@users.noreply.github.com>
…res (#898) Co-authored-by: theofficialgman <28281419+theofficialgman@users.noreply.github.com>
Co-authored-by: theofficialgman <28281419+theofficialgman@users.noreply.github.com>
Co-authored-by: theofficialgman <28281419+theofficialgman@users.noreply.github.com>
… architectures (#898) Co-authored-by: theofficialgman <28281419+theofficialgman@users.noreply.github.com>
…res (#898) Co-authored-by: theofficialgman <28281419+theofficialgman@users.noreply.github.com>
…res (#898) Co-authored-by: theofficialgman <28281419+theofficialgman@users.noreply.github.com>
Co-authored-by: theofficialgman <28281419+theofficialgman@users.noreply.github.com>
Co-authored-by: theofficialgman <28281419+theofficialgman@users.noreply.github.com>
… architectures (#898) Co-authored-by: theofficialgman <28281419+theofficialgman@users.noreply.github.com>
…res (#898) Co-authored-by: theofficialgman <28281419+theofficialgman@users.noreply.github.com>
…res (#898) Co-authored-by: theofficialgman <28281419+theofficialgman@users.noreply.github.com>
Co-authored-by: theofficialgman <28281419+theofficialgman@users.noreply.github.com>
Co-authored-by: theofficialgman <28281419+theofficialgman@users.noreply.github.com>
… architectures (#898) Co-authored-by: theofficialgman <28281419+theofficialgman@users.noreply.github.com>
…res (#898) Co-authored-by: theofficialgman <28281419+theofficialgman@users.noreply.github.com>
…res (#898) Co-authored-by: theofficialgman <28281419+theofficialgman@users.noreply.github.com>
…ftkey#898) Co-authored-by: theofficialgman <28281419+theofficialgman@users.noreply.github.com>
… architectures (shiftkey#898) Co-authored-by: theofficialgman <28281419+theofficialgman@users.noreply.github.com>
…res (shiftkey#898) Co-authored-by: theofficialgman <28281419+theofficialgman@users.noreply.github.com>
…res (shiftkey#898) Co-authored-by: theofficialgman <28281419+theofficialgman@users.noreply.github.com>
Description
Extracting out from #897 to just focus on shifting the Linux builds over to using Docker (with an earlier version of Ubuntu and a different node that supports an older
glibc).