Skip to content

Conversation

@owensmooth
Copy link
Contributor

related issue: https://github.com/shiftcommerce/shift-front-end-react/issues/373

Implements MiniBag component.
The basket icon was originally in that component but has been moved to layout.

  • Minibag pops up when you add an item to basket, this waits for the cart action to come back successful before popping up.
  • When you click the basket it renders the minibag, closes when you click the cross.

MiniBag
minibag

Add to basket
addtobasket

@owensmooth owensmooth changed the title Feature/mini bag Feature/MiniBag Apr 5, 2019
Copy link
Contributor

@hubertpompecki hubertpompecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but, as discussed, I think we should also have it so that clicking anywhere outside of the minibag causes the minibag to close.

@owensmooth owensmooth merged commit 7685c5a into develop Apr 5, 2019
@owensmooth owensmooth deleted the feature/mini-bag branch April 5, 2019 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants