toggleShowClass explicitly changed to false when toggle function is … #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owensmooth
approved these changes
Apr 23, 2019
Contributor
|
@canjoku not sure this PR is needed? There are no file changes I think shiftcommerce/shift-react-components#41 is the only one needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE 879 - My Account DropDown
Code to fix my account drop down. Simply calling onMouseOver in shift-react causes the account drop down to go into a loop whereby toggleShowClass keeps altering its reference between false and true. Explicitly settings its property to in the toggle functions seems to have mitigated the issue.