Add manual list test for https hubs. #152
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenkins
commented
Jul 11, 2025
Comment on lines
+43
to
+45
| final String hubURL = "https://testing.katta.cloud/tamarind"; | ||
| final String keycloakAuthServerUrl = "https://testing.katta.cloud/kc/realms/tamarind"; | ||
| final String clientId = "cryptomator"; |
There was a problem hiding this comment.
@dkocher keep as env vars as well?
chenkins
commented
Jul 11, 2025
| final String username = System.getenv().get("username"); | ||
| final String accountKey = System.getenv().get("account_key"); | ||
|
|
||
| final String storageProfileId = "45a3cd17-9955-4580-9e60-790d84f5785f"; |
chenkins
commented
Jul 11, 2025
Comment on lines
197
to
205
| final Scheme scheme = setup.hubURL.startsWith("https://") ? Scheme.https : Scheme.http; | ||
| final Protocol profile = factory.find(p -> p.getScheme().equals(scheme) && p.getIdentifier().equals("hub") && p.isEnabled()).getFirst(); | ||
| factory.find(p -> p.getIdentifier().equals("hub") && !p.getScheme().equals(scheme) && p instanceof Profile).stream().forEach(p -> factory.unregister((Profile) p)); | ||
| assertNotNull(factory.forName("hub")); | ||
| assertNotNull(factory.forName("s3")); | ||
| final Host hub = new Host(profile).withCredentials(new Credentials(setup.userConfig.credentials).withOauth(new OAuthTokens(setup.userConfig.credentials.getOauth() != null ? setup.userConfig.credentials.getOauth() : OAuthTokens.EMPTY))); | ||
| hub.setHostname(HostParser.parse(setup.hubURL).getHostname()); | ||
| hub.setDefaultPath(HostParser.parse(setup.hubURL).getDefaultPath()); | ||
| hub.setPort(scheme.getPort()); |
There was a problem hiding this comment.
@dkocher is there a more cyberduck-idiomatic way?
chenkins
commented
Jul 11, 2025
chenkins
force-pushed
the
feature/manual-listing
branch
from
724cf5b to
923210c
Compare
dkocher
reviewed
Jul 12, 2025
| <string>http</string> | ||
| <key>Schemes</key> | ||
| <array> | ||
| <string>http</string> |
There was a problem hiding this comment.
A custom scheme would make lookup of profile easier.
chenkins
force-pushed
the
feature/manual-listing
branch
from
923210c to
0027a42
Compare
chenkins
force-pushed
the
feature/manual-listing
branch
from
0027a42 to
42b8ab7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.