Katta Admin CLI #139
Draft
Katta Admin CLI #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenkins
force-pushed
the
feature/admin-cli
branch
from
d85ee87 to
49f2fa1
Compare
chenkins
force-pushed
the
feature/admin-cli
branch
3 times, most recently
from
c624b78 to
8a67fb0
Compare
chenkins
commented
Jul 12, 2025
admin-cli/src/main/java/cloud/katta/cli/commands/setup/AwsStsSetup.java
Outdated
Show resolved
Hide resolved
chenkins
commented
Jul 12, 2025
| @CommandLine.Option(names = {"--clientId"}, description = "Keycloak realm URL with scheme. Example: \"cryptomator\"", required = false) | ||
| String clientId; | ||
|
|
||
| @CommandLine.Option(names = {"--accessToken"}, description = "The access token. Requires admin role in the hub.", required = false) |
There was a problem hiding this comment.
Improve description if accessToken not provided.
chenkins
commented
Jul 12, 2025
| * See also: <a href="https://github.com/shift7-ch/katta-docs/blob/main/SETUP_KATTA_SERVER.md#setup-aws">Katta Docs</a>. | ||
| */ | ||
| @CommandLine.Command(name = "awsSetup", description = "Setup/update OIDC provider and roles for STS in AWS.", mixinStandardHelpOptions = true) | ||
| public class AwsStsSetup implements Callable<Void> { |
There was a problem hiding this comment.
@dkocher Add option to print out command line commands instead of applying them - or is this overkill?
chenkins
commented
Jul 12, 2025
There was a problem hiding this comment.
Add native image buildhttps://github.com/cryptomator/hub-cli/blob/develop/.github/workflows/native-image.yml
chenkins
commented
Jul 12, 2025
There was a problem hiding this comment.
Add README similar to https://github.com/cryptomator/hub-cli/blob/develop/README.md
chenkins
commented
Jul 12, 2025
| protected void call(UUID uuid, StorageProfileResourceApi storageProfileResourceApi) throws ApiException { | ||
| storageProfileResourceApi.apiStorageprofileS3Put(new StorageProfileS3Dto() | ||
| .id(uuid) | ||
| .name("AWS S3 static") |
There was a problem hiding this comment.
extract cli option
chenkins
commented
Jul 12, 2025
Comment on lines
+52
to
+54
| .region("eu-west-1") | ||
| .regions(Arrays.asList("eu-west-1", | ||
| "eu-west-2", | ||
| "eu-west-3")) |
There was a problem hiding this comment.
extract cli options
chenkins
commented
Jul 12, 2025
| protected void call(UUID uuid, StorageProfileResourceApi storageProfileResourceApi) throws ApiException { | ||
| storageProfileResourceApi.apiStorageprofileS3stsPut(new StorageProfileS3STSDto() | ||
| .id(uuid) | ||
| .name("AWS S3 STS") |
There was a problem hiding this comment.
extract cli options
chenkins
commented
Jul 12, 2025
| if(existingOIDCProvider.isEmpty()) { | ||
| final CreateOpenIdConnectProviderResponse openIDConnectProvider = iam.createOpenIDConnectProvider(CreateOpenIdConnectProviderRequest.builder() | ||
| .url(realmUrl) | ||
| .clientIDList("cryptomator", "cryptomatorhub", "cryptomatorvaults") |
There was a problem hiding this comment.
Harden conditions in trust policies on client_id and possibly role?
chenkins
commented
Jul 12, 2025
There was a problem hiding this comment.
Add MinioStsSetup as well
chenkins
commented
Jul 12, 2025
chenkins
force-pushed
the
feature/admin-cli
branch
from
8a67fb0 to
7f8649f
Compare
chenkins
force-pushed
the
feature/admin-cli
branch
6 times, most recently
from
5e1ae68 to
31f9be9
Compare
chenkins
force-pushed
the
feature/admin-cli
branch
from
31f9be9 to
329b941
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes shift7-ch/katta-server#69