Skip to content

Commit

Permalink
kitty: re-enable some tests
Browse files Browse the repository at this point in the history
These tests were disabled because of failures on nix-darwin systems due
to zshenv producing spurious output in some scenarios:

LnL7/nix-darwin#1051

The linked bug is fixed in nix-darwin, and it should be now possible to
run the tests on a fresh nix-darwin system.

Related: NixOS#312692
  • Loading branch information
booxter committed Oct 4, 2024
1 parent 19d2ec0 commit 0b1ffdb
Showing 1 changed file with 1 addition and 12 deletions.
13 changes: 1 addition & 12 deletions pkgs/applications/terminal-emulators/kitty/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -172,20 +172,9 @@ buildPythonApplication rec {

# skip failing tests due to darwin sandbox
preCheck = lib.optionalString stdenv.hostPlatform.isDarwin ''
# can be re-enabled with the next kitty release, see https://github.com/kovidgoyal/kitty/pull/7939
substituteInPlace kitty_tests/file_transmission.py \
--replace test_file_get dont_test_file_get \
--replace test_path_mapping_receive dont_test_path_mapping_receive \
--replace test_transfer_send dont_test_transfer_send
substituteInPlace kitty_tests/shell_integration.py \
--replace test_fish_integration dont_test_fish_integration
substituteInPlace kitty_tests/shell_integration.py \
--replace test_bash_integration dont_test_bash_integration
substituteInPlace kitty_tests/open_actions.py \
--replace test_parsing_of_open_actions dont_test_parsing_of_open_actions
substituteInPlace kitty_tests/ssh.py \
--replace test_ssh_connection_data dont_test_ssh_connection_data
substituteInPlace kitty_tests/fonts.py \
--replace 'class Rendering(BaseTest)' 'class Rendering'
# theme collection test starts an http server
rm tools/themes/collection_test.go
# passwd_test tries to exec /usr/bin/dscl
Expand Down

0 comments on commit 0b1ffdb

Please sign in to comment.