Fix: Could not override defaultValue for question hideNumber property s…

…urveyjs#3111
shichiyou · Jul 20, 2021 · 021aacf · 021aacf
1 parent ee41dfc
commit 021aacf
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/src/question.ts b/src/question.ts
@@ -281,7 +281,7 @@ export class Question extends SurveyElement
    * @see titleLocation
    */
   public get hideNumber(): boolean {
-    return this.getPropertyValue("hideNumber", false);
+    return this.getPropertyValue("hideNumber");
   }
   public set hideNumber(val: boolean) {
     this.setPropertyValue("hideNumber", val);

diff --git a/tests/jsonobjecttests.ts b/tests/jsonobjecttests.ts
@@ -2409,3 +2409,22 @@ QUnit.test("itemvalue enableIf property visibility test", function(assert) {
     "We show enableIf for all other properties"
   );
 });
+QUnit.test("Change default value for question.hideNumber", function(assert) {
+  assert.equal(
+    new Question("q1").hideNumber,
+    false,
+    "By default hideNumber returns false"
+  );
+  Serializer.findProperty("question", "hideNumber").defaultValue = true;
+  assert.equal(
+    new Question("q1").hideNumber,
+    true,
+    "We have override hide number"
+  );
+  Serializer.findProperty("question", "hideNumber").defaultValue = undefined;
+  assert.equal(
+    new Question("q1").hideNumber,
+    false,
+    "We made hideNumber false by default again"
+  );
+});