Fix BoardGameGeek false-positive using API validation #2626
+3
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a false-positive detection for BoardGameGeek in Sherlock.
Previously, non-existent usernames were incorrectly marked as found because Sherlock only checked the profile page URL. Now, it uses the BoardGameGeek API (
urlProbe
) to verify the username:[]
).Changes
BoardGameGeek
entry insherlock_project/resources/data.json
to useurlProbe
."errorMsg": "[]"
and"errorType": "message"
to correctly detect invalid usernames.Testing
Tested locally with postman
curl --location 'https://api.geekdo.com/api/users?username=username_that_does_not_exist_9999'
result:
[]
curl --location 'https://api.geekdo.com/api/users?username=vivekgaddam'
[
{
"type": "users",
"id": "4382477",
"userid": 4382477,
"username": "vivekgaddam",
"href": "/profile/vivekgaddam",
"firstname": "",
"lastname": "",
"city": "",
"state": "",
"country": "",
"isocountry": "",
"regdate": "2025-10-08",
"designerid": 0,
"publisherid": 0,
"hideSupporter": false,
"adminBadges": [],
"userMicrobadges": [],
"supportYears": [],
"hideName": false,
"links": [
{
"rel": "self",
"uri": "/api/users/4382477"
}
],
"canonical_link": "https://boardgamegeek.com/profile/vivekgaddam"
}
]