Skip to content

Improved single source of truth for versioning #2229

Open
@ppfeister

Description

@ppfeister

Description

Current SSOT is .__version__ defined in __init__.py. This makes packaging locally less than ideal as the default version will always be zero.

We threw this together after realizing that no poetry plugins supported it -- but it really doesn't need poetry

It's suggested that we make the pyproject the SSOT and update __init__ to use the metadata submodule of importlib. Package is build with the version number from pyproj, and when processed by sherlock, it's pulled at runtime from whatever the created bin/entry is (in theory)

from importlib.metadata import version
__version__ = version('sherlock')

Code of Conduct

  • I agree to follow this project's Code of Conduct

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    Status

    Backlog

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions