Skip to content

Add RTL support #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 14, 2017
Merged

Add RTL support #419

merged 6 commits into from
Aug 14, 2017

Conversation

PejmanNik
Copy link
Contributor

Add RTL(right to left) language support
to applay it just add dir="rtl" to the html element: <html dir="rtl">

@shentao
Copy link
Owner

shentao commented Jul 7, 2017

Could you elaborate? Also please add this change to the scr/Multiselect.vue file rather than to the dist file.

@PejmanNik
Copy link
Contributor Author

PejmanNik commented Jul 8, 2017 •
edited
Loading

Sorry for that
I fix it and add change to scr/Multiselect.vue
for more elaborate:
to make vue-multiselect support RTL language we need make text right to left so by adding dir="rtl" to the html tag of main html file, vue-multiselect support RTL.

like this:

multi
single

@shentao shentao merged commit 31b2b03 into shentao:2.0 Aug 14, 2017
@shentao
Copy link
Owner

shentao commented Aug 14, 2017

Thanks for the contribution!

@shentao shentao mentioned this pull request Mar 18, 2018
Closed
@eybarta
Copy link

eybarta commented Oct 18, 2018

sweet thx! almost did this myself, but glad I found you did first..

  • one css thing I needed to add:
    [dir=rtl] .multiselect__tags { text-align: right; }

@shentao
Copy link
Owner

shentao commented Oct 23, 2018

Would you like to provide a PR with that change? @eybarta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PejmanNik @shentao @eybarta