Make FML task runner methods virtual so that FXL adaptors in Fuchsia …

…are possible. (flutter#5921)
shenguangyao · Aug 1, 2018 · de5f535 · de5f535
1 parent 33b4123
commit de5f535
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 11 deletions.
diff --git a/fml/task_runner.cc b/fml/task_runner.cc
@@ -15,9 +15,7 @@
 namespace fml {
 
 TaskRunner::TaskRunner(fml::RefPtr<MessageLoopImpl> loop)
-    : loop_(std::move(loop)) {
-  FML_CHECK(loop_);
-}
+    : loop_(std::move(loop)) {}
 
 TaskRunner::~TaskRunner() = default;
 

diff --git a/fml/task_runner.h b/fml/task_runner.h
@@ -17,23 +17,24 @@ class MessageLoopImpl;
 
 class TaskRunner : public fml::RefCountedThreadSafe<TaskRunner> {
  public:
-  void PostTask(fml::closure task);
+  virtual void PostTask(fml::closure task);
 
-  void PostTaskForTime(fml::closure task, fml::TimePoint target_time);
+  virtual void PostTaskForTime(fml::closure task, fml::TimePoint target_time);
 
-  void PostDelayedTask(fml::closure task, fml::TimeDelta delay);
+  virtual void PostDelayedTask(fml::closure task, fml::TimeDelta delay);
 
-  bool RunsTasksOnCurrentThread();
+  virtual bool RunsTasksOnCurrentThread();
+
+  virtual ~TaskRunner();
 
   static void RunNowOrPostTask(fml::RefPtr<fml::TaskRunner> runner,
                                fml::closure task);
 
- private:
-  fml::RefPtr<MessageLoopImpl> loop_;
-
+ protected:
   TaskRunner(fml::RefPtr<MessageLoopImpl> loop);
 
-  ~TaskRunner();
+ private:
+  fml::RefPtr<MessageLoopImpl> loop_;
 
   FML_FRIEND_MAKE_REF_COUNTED(TaskRunner);
   FML_FRIEND_REF_COUNTED_THREAD_SAFE(TaskRunner);