Bug 982075 - Make addEntriesToListFile() in buildlist.py deterministi…

…c. r=ted
shellylin · Mar 18, 2014 · d6d4b9c · d6d4b9c
1 parent 895f37b
commit d6d4b9c
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/python/mozbuild/mozbuild/action/buildlist.py b/python/mozbuild/mozbuild/action/buildlist.py
@@ -26,12 +26,11 @@ def addEntriesToListFile(listFile, entries):
       f.close()
     else:
       existing = set()
-    f = open(listFile, 'a')
     for e in entries:
       if e not in existing:
-        f.write("{0}\n".format(e))
         existing.add(e)
-    f.close()
+    with open(listFile, 'w') as f:
+      f.write("\n".join(sorted(existing))+"\n")
   finally:
     lock = None