docs: Correct location of assetHookStage in readme
#290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschristian
changed the title
assetHookStage docsassetHookStage in readme
Owner
|
Thanks for catching this. Please put the option in alphabetical order in that section and we'll be able to merge. |
Contributor
Author
|
Whoops, don't know how I missed the alphabetical order. Sorry about that. Should be corrected now. |
Owner
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
Description
It seems this option text was misplaced.
Reading through the docs, I was a bit baffled as to how
assetHookStagewas intended to be used seeing as how it was listed next togetCompilerHooks, which is an export. The "Usage" section that immediately follows is also entirely unrelated to this functionality, which was confusing.This also corrects the formatting to ensure the type and default values are on different lines, matching the rest of the options.