Skip to content

Allow webpack 5 as peer dependency#271

Merged
shellscape merged 1 commit intoshellscape:masterfrom
jorrit:webpack5
Jul 27, 2021
Merged

Allow webpack 5 as peer dependency#271
shellscape merged 1 commit intoshellscape:masterfrom
jorrit:webpack5

Conversation

@jorrit
Copy link
Contributor

@jorrit jorrit commented Jul 27, 2021

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers: #270

@jorrit jorrit marked this pull request as ready for review July 27, 2021 09:10
@codecov-commenter
Copy link

Codecov Report

Merging #271 (86dbfe6) into master (1b9142e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #271   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          122       122           
=========================================
  Hits           122       122           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b9142e...86dbfe6. Read the comment docs.

@jorrit
Copy link
Contributor Author

jorrit commented Jul 29, 2021

This PR was reverted by 830a1b2.

@shellscape
Copy link
Owner

It actually wasn't. It was reverted by the previous commit, and reinstated by the commit you referenced.

@jorrit
Copy link
Contributor Author

jorrit commented Jul 29, 2021

Sorry, I shouldn't have commented before the third coffee in the morning. My apologies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants