Skip to content

Conversation

@jwilsson
Copy link
Collaborator

Which issue # if any, does this resolve?
#129

Please check one:

  • New tests created for this change
  • Tests updated for this change

This PR:

  • Adds new API
  • Extends existing API, backwards-compatible
  • Introduces a breaking change
  • Fixes a bug

@codecov-io
Copy link

Codecov Report

Merging #131 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #131      +/-   ##
==========================================
+ Coverage   96.47%   96.49%   +0.01%     
==========================================
  Files           8        8              
  Lines         227      228       +1     
==========================================
+ Hits          219      220       +1     
  Misses          8        8
Impacted Files Coverage Δ
lib/nodes/inline-comment.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e7bf62...baf8ee3. Read the comment docs.

@shellscape
Copy link
Owner

LGTM.

Question: Is this a fix or a breaking change? I can't arrive at a decision on that.

@shellscape shellscape merged commit 714ce13 into master Dec 27, 2018
@jwilsson jwilsson deleted the issue-129 branch December 27, 2018 15:34
@jwilsson
Copy link
Collaborator Author

I wanna say it's a bug fix for a 3.0 regression, because the 2.0 behaviour was putting new lines in raws.before.

@shellscape
Copy link
Owner

shellscape commented Dec 27, 2018

Sounds good to me. 😅 here's hoping a patch doesn't bork the world. I'll get this published later on today. Thanks for getting a fix in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants