Extra semicolon produced by mixins

[davidtheclark]

Tied to stylelint/stylelint#1389

Given the following:

.foo { .thing(); }

I end up with a rule node that erroneously has a ; in raws.after. The rule node that is produced when rendered to a string (node.toString()) looks like this: .foo { .thing(){}; }. Looking at that, it's clear that the semicolon is superfluous.

[webschik]

Thanks, @davidtheclark!

I will check it asap.

[kachkaev]

Hi @webschik,

Any updates on this by a chance? Looks like this bug causes a problem in atom-linter – see the referenced issue above.

[webschik]

Hi @kachkaev,

sorry, I didn't have a time for the task. I will try to resolve this issue this week.

[webschik]

Hi guys,

Probably I don't understand the problem: if you don't want to have an extra semicolon, just write your LESS in correct way:

.foo { .thing() }

and postcss-less returns this result from toString() without extra semicolon. But if somebody wants always have an extra semicolons, he can write

.foo { .thing(); }

and postcss-less also return the correct output as input.

I don't think that it's a good idea if postcss-less will be reformat the input code.

[kachkaev]

Hi @webschik,

The problem that I see here is that the current behaviour produces wrong error positions during linting. These have to be precise for any input code and now it is not the case. How would you recommend solving stylelint/stylelint#1409?

[webschik]

@kachkaev, I see. I will check why the positions are incorrect.

[webschik]

I've fixed the bug with positioning and released a version 0.13.0.

Now for code

.class {
  .mixin2;
}

an error is on line 2, column 10