Skip to content

chore: drop non-LTS node versions #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2025
Merged

chore: drop non-LTS node versions #229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 0 additions & 25 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ name: CI
on:
- push
- pull_request
env:
ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true
jobs:
test:
name: Node.js ${{ matrix.node-version }} on ${{ matrix.os }}
Expand All @@ -13,35 +11,12 @@ jobs:
matrix:
node-version:
- 18
- 19
- 20
- 21
- 22
os:
- ubuntu-latest
- macos-latest
- windows-latest
exclude:
- node-version: 6
os: macos-latest
- node-version: 7
os: macos-latest
- node-version: 8
os: macos-latest
- node-version: 9
os: macos-latest
- node-version: 10
os: macos-latest
- node-version: 11
os: macos-latest
- node-version: 12
os: macos-latest
- node-version: 13
os: macos-latest
- node-version: 14
os: macos-latest
- node-version: 15
os: macos-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
commands, providing an easy solution for simple Unix-like, cross-platform
commands in npm package scripts.

`shx` is proudly tested on every node release since <!-- start minVersion -->`v18`<!-- stop minVersion -->!
`shx` is proudly tested on every LTS node release since <!-- start minVersion -->`v18`<!-- stop minVersion -->!

## Difference Between ShellJS and shx

Expand Down
7 changes: 5 additions & 2 deletions scripts/check-node-support.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,10 @@ function assertDeepEquals(arr1, arr2, msg) {

function range(start, stop) {
var ret = [];
for (var i = start; i <= stop; i++) {
for (var i = start; i <= stop; i += 2) {
if (i % 2 !== 0) {
console.warn('Warning: testing a non-LTS nodejs release: ' + i);
}
ret.push(i);
}
return ret;
Expand All @@ -68,7 +71,7 @@ try {
var githubActionsYaml = yaml.load(shell.cat(githubActionsFileName));
checkGithubActions(MIN_NODE_VERSION, MAX_NODE_VERSION, githubActionsYaml);

console.log('All files look good (this project supports v'
console.log('All files look good (this project supports LTS releases v'
+ MIN_NODE_VERSION + '-v' + MAX_NODE_VERSION + ')!');
} catch (e) {
console.error('Please check the files which declare our Node version');
Expand Down