Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added appendTo() function to imitate '>>' redirect-and-append pipe. #75

Merged
merged 1 commit into from
Aug 26, 2013
Merged

Conversation

a10y
Copy link

@a10y a10y commented Aug 25, 2013

@arturadib updated to your newer version. Passes tests on my machine (MBP OSX 10.8.4 node v0.10.8) hopefully will pass on travis as well!

@arturadib
Copy link
Collaborator

Looks good. I had screwed up the Travis config, let me merge and see what happens :) Thanks!

arturadib added a commit that referenced this pull request Aug 26, 2013
Added appendTo() function to imitate '>>' redirect-and-append pipe.
@arturadib arturadib merged commit 6ad2777 into shelljs:master Aug 26, 2013
@arturadib
Copy link
Collaborator

Hi there, really sorry Andrew, but I overlooked some issues and decided to revert the patch. Can you please reopen the PR addressing these issues:

  • Rename the function to .toEnd(), so that it's nicely grouped with .to() in the dir list (I know, I know, I'm sorry, I can be anal about naming :) Last time, I promise)
  • Update the in-source docs in src/toEnd.js, and run scripts/generate-docs.js which will update README.md for you
  • Create an explicit test showing that it creates a file if it does not exist (first test to confirm it doesn't exist, then show it exists with the right content)

Really appreciate your contribution, many thanks!

@a10y
Copy link
Author

a10y commented Aug 26, 2013

No need to apologize, I should have made it more compliant to start with :)
I'll send in the updated PR now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants