-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(touch): supports multiple files #346
Conversation
} else { | ||
if (!files) | ||
common.error('no files given'); | ||
else if (Array.isArray(files)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to do a no-op. For what it's worth, I think #352 will make this line obsolete, so we might want to wait until that's merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll rebase and update this tonight or tomorrow. Thanks!
d99524a
to
19721fc
Compare
@ariporad this should be fixed now |
LGTM! Will merge once Travis is done. |
LGTM! |
feat(touch): supports multiple files
Does what it says. From the (updated) docs:
This is consistent with the API for
ls()
,cp()
,mv()
,rm()
, etc.