Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(touch): supports multiple files #346

Merged
merged 1 commit into from
Feb 16, 2016
Merged

Conversation

nfischer
Copy link
Member

@nfischer nfischer commented Feb 9, 2016

Does what it says. From the (updated) docs:

touch([options,] file [, file ...])
touch([options,] file_array)

This is consistent with the API for ls(), cp(), mv(), rm(), etc.

@nfischer nfischer added feature medium priority bash compat Compatibility issues with bash or POSIX behavior labels Feb 9, 2016
@nfischer nfischer added this to the v0.7.0 milestone Feb 9, 2016
} else {
if (!files)
common.error('no files given');
else if (Array.isArray(files))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to do a no-op. For what it's worth, I think #352 will make this line obsolete, so we might want to wait until that's merged

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nfischer: Ok, #352 is merged.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll rebase and update this tonight or tomorrow. Thanks!

@nfischer
Copy link
Member Author

@ariporad this should be fixed now

@ariporad
Copy link
Contributor

LGTM! Will merge once Travis is done.

@ariporad
Copy link
Contributor

LGTM!

ariporad added a commit that referenced this pull request Feb 16, 2016
feat(touch): supports multiple files
@ariporad ariporad merged commit bceac92 into master Feb 16, 2016
@ariporad ariporad deleted the touch-multiple-files branch February 16, 2016 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bash compat Compatibility issues with bash or POSIX behavior feature medium priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants