New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor more commands to return ShellString #373

Closed

nfischer opened this issue Feb 25, 2016 · 1 comment

Member

nfischer commented Feb 25, 2016

This will let each command return some sort of output. So commands like cd() will return output along the lines of:

{ stdout: '', stderr: /*some error message*/, code: 0, ... }

Commands that should probably be left as-is:

set() - it has nothing interesting to return, since it never fails
test() - returning a boolean as it currently does is probably the right move

The text was updated successfully, but these errors were encountered:

Member Author

nfischer commented Mar 17, 2016

This is resolved in #394

nfischer closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment