fix(ui): replace text-white with theme-safe emphasis colors #5653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luannmoreira
added
kind/bug
Remove hardcoded text-white styles that break readability in light theme and replace them with Vuetify emphasis classes. Introduce reusable hyper-link styling that inherits theme color for consistent behavior across light and dark modes. Update affected tests to reflect the new styling.
luannmoreira
force-pushed
the
fix/ui-light-theme-text-colors
branch
from
0b3a9e2 to
1c80d3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes multiple UI text contrast issues that occur when using the
light theme. Several components relied on hardcoded text-white styles,
which made text unreadable on light backgrounds.
The fix replaces those styles with Vuetify theme-aware emphasis classes
and introduces a reusable hyperlink style that inherits the active theme
color.
What changed
Replaced
text-whitewithtext-high-emphasisandtext-medium-emphasisacross admin and user UIsAdded a
.hyper-linkclass for router links that respects theme colorsUpdated layout and welcome screens to use theme-safe text styles
Adjusted unit tests impacted by the removal of
text-whiteWhy this change
text-white breaks readability in light mode
Vuetify provides built-in emphasis utilities designed for theming
Ensures consistent behavior across light and dark themes
Improves accessibility and visual consistency
Testing
Verified affected screens in both light and dark themes
Unit tests updated and passing