Skip to content

feat(agent): add support for optional environment variables in install.sh #5613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gustavosbarreto merged 1 commit into from
Dec 9, 2025
Merged

feat(agent): add support for optional environment variables in install.sh #5613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion agent/packaging/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,10 @@
"PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin",
"SHELLHUB_SERVER_ADDRESS=__SERVER_ADDRESS__",
"SHELLHUB_TENANT_ID=__TENANT_ID__",
"SHELLHUB_PRIVATE_KEY=/host/etc/shellhub.key"
"SHELLHUB_PRIVATE_KEY=/host/etc/shellhub.key",
"__PREFERRED_HOSTNAME__",
"__PREFERRED_IDENTITY__",
"__KEEPALIVE_INTERVAL__"
],
"cwd": "/",
"capabilities": {
Expand Down
27 changes: 27 additions & 0 deletions install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,14 @@ snap_install() {
sudo snap set shellhub preferred-hostname="${PREFERRED_HOSTNAME}"
fi

if [ -n "${PREFERRED_IDENTITY}" ]; then
sudo snap set shellhub preferred-identity="${PREFERRED_IDENTITY}"
fi

if [ -n "${KEEPALIVE_INTERVAL}" ]; then
sudo snap set shellhub keepalive-interval="${KEEPALIVE_INTERVAL}"
fi

sudo snap set shellhub server-address="$SERVER_ADDRESS"
sudo snap set shellhub tenant-id="$TENANT_ID"
sudo snap set shellhub private-key="${PRIVATE_KEY:-/etc/shellhub.key}"
Expand Down Expand Up @@ -210,6 +218,25 @@ standalone_install() {
sed -i "s,__ROOT_PATH__,$INSTALL_DIR/rootfs,g" $TMP_DIR/config.json
sed -i "s,__INSTALL_DIR__,$INSTALL_DIR,g" $TMP_DIR/shellhub-agent.service

# Handle optional environment variables
if [ -n "${PREFERRED_HOSTNAME}" ]; then
sed -i "s,__PREFERRED_HOSTNAME__,SHELLHUB_PREFERRED_HOSTNAME=$PREFERRED_HOSTNAME,g" $TMP_DIR/config.json
else
sed -i '/"__PREFERRED_HOSTNAME__"/d' $TMP_DIR/config.json
fi

if [ -n "${PREFERRED_IDENTITY}" ]; then
sed -i "s,__PREFERRED_IDENTITY__,SHELLHUB_PREFERRED_IDENTITY=$PREFERRED_IDENTITY,g" $TMP_DIR/config.json
else
sed -i '/"__PREFERRED_IDENTITY__"/d' $TMP_DIR/config.json
fi

if [ -n "${KEEPALIVE_INTERVAL}" ]; then
sed -i "s,__KEEPALIVE_INTERVAL__,SHELLHUB_KEEPALIVE_INTERVAL=$KEEPALIVE_INTERVAL,g" $TMP_DIR/config.json
else
sed -i '/"__KEEPALIVE_INTERVAL__"/d' $TMP_DIR/config.json
fi

echo "🚀 Starting ShellHub system service..."

$SUDO cp $TMP_DIR/shellhub-agent.service /etc/systemd/system/shellhub-agent.service
Expand Down