Skip to content

Conversation

@luannmoreira
Copy link
Member

Description

This PR resolves a visual bug where the layout container appeared semi-transparent, allowing content underneath to show through in light mode. It also improves the testability and accessibility of layout components.

Changes

  • Added container-light-bg class in light theme for correct background styling
  • Replaced empty alt on <v-img> with a meaningful alt on <v-progress-circular>
  • Added data-test attributes to:
    • <v-main>
    • <v-container>
    • <v-overlay>
    • <v-progress-circular>
  • Changed style block from css to scss for future flexibility
  • Updated relevant unit test snapshots

Reason

These improvements ensure visual consistency in light mode and enhance the reliability of automated tests via improved selectors.

Testing

  • Verified layout renders correctly across themes
  • Confirmed updated bindings and attributes work as expected
  • Snapshot tests updated to match new DOM structure

@luannmoreira luannmoreira self-assigned this Dec 3, 2025
@luannmoreira luannmoreira requested a review from a team as a code owner December 3, 2025 11:40
@luannmoreira luannmoreira force-pushed the fix/admin-table-opacity-and-layout-tests branch 3 times, most recently from 193c136 to 3c3be14 Compare December 3, 2025 11:43
Ensure layout container uses proper background in light theme.
Add data-test attributes to improve component testability.
Fix v-model binding issue on overlay component.
@luannmoreira luannmoreira force-pushed the fix/admin-table-opacity-and-layout-tests branch from 3c3be14 to 1b1ee1c Compare December 3, 2025 11:49
@otavio otavio requested a review from luizhf42 December 5, 2025 14:56
@gustavosbarreto gustavosbarreto merged commit e0b9ddf into master Dec 9, 2025
8 checks passed
@gustavosbarreto gustavosbarreto deleted the fix/admin-table-opacity-and-layout-tests branch December 9, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants