fix(ui): align Device & FirewallRules tests with tag objects #5250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch tags from strings to objects in mocks and snapshots Rename mock lists: mockDevices→devices; mockFirewallRules→firewallRules Update device fields: remote_addr→remoteAddr, mac/keys sanitized Adjust OS info, namespace, timestamps, and status icons in snapshots Add a second device and corresponding snapshot row Update tooltip ids and chip content to reflect new data
otavio
approved these changes
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the admin UI unit tests and snapshots for Device and FirewallRules to align with the updated backend model where tags are now represented as objects instead of simple strings.
It also refreshes mock data to reflect the new schema and updates related snapshots accordingly.
Changes
Tags
Converted tags from strings to objects ({ tenant_id, name, created_at, updated_at }).
Updated snapshots to display test-tag instead of old string values (tag1, xxxx, yyyy).
Device tests
Updated fields
FirewallRules tests