fix(api): some tag behaviours #5248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change devices collection update to pull from tag_ids field - Update public_keys and firewall_rules collections to pull from filters.tag_ids field
- Replace FindOneAndUpdate with UpdateOne and Aggregate operations - Add conversion of string tag_ids to ObjectID for referential integrity - Implement lookup to populate filter.tags from tags collection
…uation - Add DeviceResolve call to get complete device data with tag_ids - Add proper error handling for device resolution failures - Update tests to mock DeviceResolve calls and verify tag filtering logic
heiytor
force-pushed
the
fix/api/tags
branch
from
7b2f0ae to
d465a22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.